feat(errors): Allow searching for errors #25175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 9.21 MB ℹ️ View Unchanged
|
neilkakkar
commented
Sep 26, 2024
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
neilkakkar
commented
Sep 27, 2024
daibhin
approved these changes
Sep 30, 2024
|
|
||
| self.assertEqual(len(results), 1) | ||
| self.assertEqual(results[0]["fingerprint"], ["DatabaseNotFound"]) | ||
| self.assertEqual(results[0]["occurrences"], 1) |
There was a problem hiding this comment.
I think the negative case is only implicitly tested e.g. what happens when the search query doesn't match - do we get 0 results?
neilkakkar
commented
Oct 1, 2024
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
^^ Opted to add this to the query runner rather than manipulate filter groups in the frontend because I imagine this can get complicated. Easier to isolate, test and update this logic as and when the search function changes in the backend.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?